From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Mon, 21 Sep 2015 17:40:05 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Vincent =?iso-8859-1?Q?Stehl=E9?= <vincent.stehle@freescale.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>, trivial@kernel.org
Subject: Re: [PATCH] fs/super.c: use && instead of & for warn_on condition
Message-ID: <20150921154005.GA22742@redhat.com>
References: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 09/21, Vincent Stehl� wrote:
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
>  	else
>  		ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
>
> -	WARN_ON(force_trylock & !ret);
> +	WARN_ON(force_trylock && !ret);

OOPS! yes, this is a typo, thanks! Harmless in this particular case,
but still.

Acked-by: Oleg Nesterov <oleg@redhat.com>