From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 08/15] block, dax, pmem: reference counting infrastructure Date: Fri, 25 Sep 2015 04:32:06 -0700 Message-ID: <20150925113206.GA22272@infradead.org> References: <20150923043737.36490.70547.stgit@dwillia2-desk3.jf.intel.com> <20150923044155.36490.2017.stgit@dwillia2-desk3.jf.intel.com> <20150924151503.GF24375@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Andrew Morton , Jens Axboe , linux-nvdimm , "linux-kernel@vger.kernel.org" , Linux MM , linux-fsdevel , Ross Zwisler To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Sep 24, 2015 at 05:03:18PM -0700, Dan Williams wrote: > That makes sense to me, especially because drivers/nvdimm/blk.c is > broken in the same way as drivers/nvdimm/pmem.c and it would be > awkward to have it use blk_dax_get() / blk_dax_put(). The > percpu_refcount should be valid for all queues and it will only ever > be > 1 in the blk_mq and libnvdimm cases (for now). Will fix. Looking at this a bit more it might actually make sense to grab the referene in common code before calling into ->make_request. Jens, any opinion on that? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org