From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yaowei Bai <bywxiaobai@163.com>
Subject: Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check
Date: Tue, 29 Sep 2015 23:46:32 +0800
Message-ID: <20150929154631.GA6489@bbox>
References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
 <1443447836-5178-1-git-send-email-bywxiaobai@163.com>
 <560A9672.9@electrozaur.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@zeniv.linux.org.uk, bhalevy@primarydata.com,
	osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Boaz Harrosh <ooo@electrozaur.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <560A9672.9@electrozaur.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Sep 29, 2015 at 04:47:30PM +0300, Boaz Harrosh wrote:
> On 09/28/2015 04:43 PM, Yaowei Bai wrote:
> > As new_valid_dev always returns 1, so !new_valid_dev check is not
> > needed, remove it.
> > 
> > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> 
> ACK-by: Boaz Harrosh <ooo@electrozaur.com>

Thanks.

> 
> Please submit this through some General tree like the vfs or mm-tree

This's my first fs-specific patch, so i think you mean i should cc vfs
or mm-tree?

> 
> Thanks
> Boaz
> 
> > ---
> >  fs/exofs/namei.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c
> > index 09a6bb1..994e078 100644
> > --- a/fs/exofs/namei.c
> > +++ b/fs/exofs/namei.c
> > @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
> >  	struct inode *inode;
> >  	int err;
> >  
> > -	if (!new_valid_dev(rdev))
> > -		return -EINVAL;
> > -
> >  	inode = exofs_new_inode(dir, mode);
> >  	err = PTR_ERR(inode);
> >  	if (!IS_ERR(inode)) {
> >