From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>,
Ron Minnich <rminnich@sandia.gov>,
Latchesar Ionkov <lucho@ionkov.net>,
v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH v2 5/7] 9p: xattr simplifications
Date: Sat, 3 Oct 2015 23:27:09 -0700 [thread overview]
Message-ID: <20151004062709.GD28519@infradead.org> (raw)
In-Reply-To: <1442924812-9384-6-git-send-email-agruenba@redhat.com>
On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote:
>
> +/**
> + * xattr_full_name - Compute full attribute name from suffix
> + *
Missing argument descriptions for a kdoc comment.
> +const char *xattr_full_name(const struct xattr_handler *handler,
> + const char *name)
> +{
> + size_t prefix_len = strlen(handler->prefix);
> +
> + /* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */
This either should be a real WARN_ON or go away.
next prev parent reply other threads:[~2015-10-04 6:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 12:26 [PATCH v2 0/7] Pass xattr handler to xattr handler operations Andreas Gruenbacher
2015-09-22 12:26 ` [PATCH v2 1/7] ubifs: Remove unused security xattr handler Andreas Gruenbacher
2015-09-22 12:41 ` Richard Weinberger
2015-09-22 12:47 ` Andreas Gruenbacher
2015-09-22 12:26 ` [PATCH v2 2/7] hfsplus: Remove unused xattr handler list operations Andreas Gruenbacher
2015-10-04 6:24 ` Christoph Hellwig
2015-09-22 12:26 ` [PATCH v2 3/7] jffs2: Add missing capability check for listing trusted xattrs Andreas Gruenbacher
2015-10-04 6:25 ` Christoph Hellwig
2015-09-22 12:26 ` [PATCH v2 4/7] xattr handlers: Pass handler to operations instead of flags Andreas Gruenbacher
2015-10-04 6:25 ` Christoph Hellwig
2015-09-22 12:26 ` [PATCH v2 5/7] 9p: xattr simplifications Andreas Gruenbacher
2015-10-04 6:27 ` Christoph Hellwig [this message]
2015-09-22 12:26 ` [PATCH v2 6/7] squashfs: " Andreas Gruenbacher
2015-10-04 6:29 ` Christoph Hellwig
2015-10-04 13:10 ` Andreas Grünbacher
2015-09-22 12:26 ` [PATCH v2 7/7] f2fs: " Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004062709.GD28519@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).