From: Yaowei Bai <bywxiaobai@163.com>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check
Date: Thu, 8 Oct 2015 20:22:01 +0800 [thread overview]
Message-ID: <20151008122201.GA3711@bbox> (raw)
In-Reply-To: <alpine.DEB.2.00.1510012245420.24646@leontynka>
On Thu, Oct 01, 2015 at 10:49:41PM +0200, Mikulas Patocka wrote:
>
>
> On Wed, 30 Sep 2015, Yaowei Bai wrote:
>
> > On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote:
> > > Hi
> > >
> > > I suppose that you should remove the function new_valid_dev at all.
> >
> > Yes, i thought about that, but actually there's still a user of
> > new_valid_dev in fs/stat.c:
> >
> > #define valid_dev(x) choose_32_64(old_valid_dev,new_valid_dev)(x)
> >
> > so i just left new_valid_dev untouched and removed other users in fs first.
>
> So, remove that too - change it to choose_32_64(old_valid_dev(x),true)
>
> If you remove most calls for the function new_valid_dev, the function is
> meaningless and shouldn't be present in the source code.
Sorry for delay reply. OK, i will follow your advice and send another patch to
remove it once this patchset's taken by vfs or mm tree. Thanks for reviewing.
Yaowei
>
> Mikulas
next prev parent reply other threads:[~2015-10-08 12:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 13:26 [PATCH 00/17] cleanups of fs about new/huge_valid_dev Yaowei Bai
2015-09-28 13:29 ` [PATCH 01/17] fs/kdev_t: remove unused huge_valid_dev function Yaowei Bai
2015-09-28 13:29 ` [PATCH 02/17] fs/kdev_t: old/new_valid_dev can be boolean Yaowei Bai
2015-09-28 13:34 ` [PATCH 03/17] fs/vfs: remove unnecessary new_valid_dev check Yaowei Bai
2015-09-28 13:39 ` [PATCH 04/17] fs/btrfs: " Yaowei Bai
2015-09-29 14:55 ` David Sterba
2015-09-28 13:43 ` [PATCH 05/17] fs/exofs: " Yaowei Bai
2015-09-29 13:47 ` Boaz Harrosh
2015-09-29 15:46 ` Yaowei Bai
2015-09-30 10:26 ` Boaz Harrosh
2015-10-08 12:29 ` Yaowei Bai
2015-09-28 13:47 ` [PATCH 06/17] fs/ext2: " Yaowei Bai
2015-09-28 13:50 ` [PATCH 07/17] fs/ext4: " Yaowei Bai
2015-10-29 18:09 ` Theodore Ts'o
2015-10-30 1:38 ` Yaowei Bai
2015-09-28 13:55 ` [PATCH 08/17] fs/f2fs: " Yaowei Bai
2015-09-28 14:11 ` [PATCH 09/17] fs/hpfs: " Yaowei Bai
2015-09-29 15:03 ` Mikulas Patocka
2015-09-30 11:13 ` Yaowei Bai
2015-10-01 20:49 ` Mikulas Patocka
2015-10-08 12:22 ` Yaowei Bai [this message]
2015-09-28 14:15 ` [PATCH 10/17] fs/jffs2: " Yaowei Bai
2015-09-28 23:20 ` Brian Norris
2015-09-28 14:18 ` [PATCH 11/17] fs/jfs: " Yaowei Bai
2015-09-28 15:42 ` [Jfs-discussion] " Dave Kleikamp
2015-09-28 14:21 ` [PATCH 06/17] fs/ext2: " Yaowei Bai
2015-09-28 14:25 ` [PATCH 12/17] fs/ncpfs: " Yaowei Bai
[not found] ` <1443446807-4838-1-git-send-email-bywxiaobai-9Onoh4P/yGk@public.gmane.org>
2015-09-28 14:30 ` [PATCH 13/17] fs/nfs: " Yaowei Bai
2015-09-28 14:33 ` [PATCH 14/17] fs/nilfs2: " Yaowei Bai
[not found] ` <1443450823-5692-1-git-send-email-bywxiaobai-9Onoh4P/yGk@public.gmane.org>
2015-09-29 14:51 ` Ryusuke Konishi
2015-09-28 14:47 ` [PATCH 15/17] fs/reiserfs: " Yaowei Bai
2015-09-28 14:50 ` [PATCH 16/17] fs/stat: " Yaowei Bai
2015-09-28 14:53 ` [PATCH 17/17] fs/ubifs: " Yaowei Bai
2015-09-28 19:20 ` Richard Weinberger
2015-09-29 13:43 ` Yaowei Bai
2015-09-29 13:57 ` [PATCH] " Yaowei Bai
2015-09-30 8:11 ` Richard Weinberger
2015-10-01 13:35 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008122201.GA3711@bbox \
--to=bywxiaobai@163.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikulas@twibright.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).