From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v8 1/5] configfs: Allow dynamic group creation
Date: Thu, 22 Oct 2015 10:40:34 +0200
Message-ID: <20151022084034.GA21923@lst.de>
References: <1445338426-4126-1-git-send-email-daniel.baluta@intel.com> <1445338426-4126-2-git-send-email-daniel.baluta@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org, patrick.porlan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	adriana.reus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, constantin.musca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	marten-4zOpVvZifTgX8gGd4fc/mEEOCMrvLtNR@public.gmane.org, cristina.opriceana-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, hch-jcswGhMUV9g@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
To: Daniel Baluta <daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <1445338426-4126-2-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote:
> We don't want to hardcode default groups at subsystem
> creation time. We export:
> 	* configfs_register_group
> 	* configfs_unregister_group
> to allow drivers to programatically create/destroy groups
> later, after module init time.
> 
> This is needed for IIO configfs support.

This looks like a good start, and maybe we should merge it as is given
that merge window is about to end.  But I have two requests, one trivial
and one not so:

 a) please provide kerneldoc comments for the new functions
 b) just pass the name and item type and dynamically allocate the
    actua group. With that we can avoid a lot of boilerplate code and
    could also replace the horrible static sized defaults_groups array
    in current users with your new function.