From: Christoph Hellwig <hch@lst.de>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org,
linux-fsdevel@vger.kernel.org, lars@metafoo.de, hch@lst.de,
knaack.h@gmx.de, linux-kernel@vger.kernel.org,
octavian.purdila@intel.com, pebolle@tiscali.nl,
patrick.porlan@intel.com, adriana.reus@intel.com,
constantin.musca@intel.com, marten@intuitiveaerial.com,
cristina.opriceana@gmail.com, pmeerw@pmeerw.net,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH v9 1/5] configfs: Allow dynamic group creation
Date: Fri, 23 Oct 2015 14:48:12 +0200 [thread overview]
Message-ID: <20151023124812.GA4588@lst.de> (raw)
In-Reply-To: <1445603558-27693-2-git-send-email-daniel.baluta@intel.com>
Hi Daniel,
all these functions look great, but can you also move your new
iio_sw_trigger_type_configfs_register/unregister functions to the
core code as those are the wrappers that everyone would have to write,
e.g. something like:
int configfs_register_default_group(struct config_group *parent_group,
const char *name, struct config_item_type *item_type)
{
struct config_group *group;
group = kzalloc(sizeof(*group), GFP_KERNEL);
if (!group)
return -ENOMEM;
config_group_init_type_name(group, name, item_type);
ret = configfs_register_group(parent_group, group);
if (ret)
kfree(group);
return ret;
}
and the same on the unregister side?
With that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-10-23 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:32 [PATCH v9 0/5] Add initial configfs support for IIO Daniel Baluta
2015-10-23 12:32 ` [PATCH v9 1/5] configfs: Allow dynamic group creation Daniel Baluta
2015-10-23 12:48 ` Christoph Hellwig [this message]
2015-10-23 13:08 ` Daniel Baluta
2015-10-23 14:09 ` Daniel Baluta
2015-10-23 12:32 ` [PATCH v9 2/5] iio: core: Introduce IIO configfs support Daniel Baluta
2015-10-23 12:32 ` [PATCH v9 3/5] iio: core: Introduce IIO software triggers Daniel Baluta
2015-10-23 12:32 ` [PATCH v9 4/5] iio: trigger: Introduce IIO hrtimer based trigger Daniel Baluta
[not found] ` <1445603558-27693-5-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-24 9:10 ` Matt Ranostay
2015-10-23 12:32 ` [PATCH v9 5/5] iio: Documentation: Add IIO configfs documentation Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023124812.GA4588@lst.de \
--to=hch@lst.de \
--cc=adriana.reus@intel.com \
--cc=akpm@linux-foundation.org \
--cc=constantin.musca@intel.com \
--cc=cristina.opriceana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=jlbec@evilplan.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marten@intuitiveaerial.com \
--cc=octavian.purdila@intel.com \
--cc=patrick.porlan@intel.com \
--cc=pebolle@tiscali.nl \
--cc=pmeerw@pmeerw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).