From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Fri, 23 Oct 2015 14:48:12 +0200
From: Christoph Hellwig <hch@lst.de>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, lars@metafoo.de, hch@lst.de,
	knaack.h@gmx.de, linux-kernel@vger.kernel.org,
	octavian.purdila@intel.com, pebolle@tiscali.nl,
	patrick.porlan@intel.com, adriana.reus@intel.com,
	constantin.musca@intel.com, marten@intuitiveaerial.com,
	cristina.opriceana@gmail.com, pmeerw@pmeerw.net,
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH v9 1/5] configfs: Allow dynamic group creation
Message-ID: <20151023124812.GA4588@lst.de>
References: <1445603558-27693-1-git-send-email-daniel.baluta@intel.com> <1445603558-27693-2-git-send-email-daniel.baluta@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445603558-27693-2-git-send-email-daniel.baluta@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi Daniel,

all these functions look great, but can you also move your new
iio_sw_trigger_type_configfs_register/unregister functions to the
core code as those are the wrappers that everyone would have to write,
e.g. something like:

int configfs_register_default_group(struct config_group *parent_group,
		const char *name, struct config_item_type *item_type)
{
	struct config_group *group;

	group = kzalloc(sizeof(*group), GFP_KERNEL);
	if (!group)
		return -ENOMEM;
	config_group_init_type_name(group, name, item_type);

	ret = configfs_register_group(parent_group, group);
	if (ret)
		kfree(group);
	return ret;
}

and the same on the unregister side?

With that:

Reviewed-by: Christoph Hellwig <hch@lst.de>