From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin LaHaise Subject: Re: [PATCH] aio: Add few code style fixes Date: Wed, 11 Nov 2015 11:33:03 -0500 Message-ID: <20151111163303.GC25317@kvack.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: viro@zeniv.linux.org.uk, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: =?utf-8?B?5YiY6ZW/5Yas?= Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 11, 2015 at 11:28:08PM +0800, =E5=88=98=E9=95=BF=E5=86=AC wro= te: > >From 1609d68dee344925d182631922cd98790109588b Mon Sep 17 00:00:00 2001 > From: Liu Changdong > Date: Tue, 10 Nov 2015 00:04:18 +0800 > Subject: [PATCH] aio: Add few code style fixes >=20 > Add a blank line after declarations >=20 > Signed-off-by: Liu Changdong > --- > fs/aio.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/fs/aio.c b/fs/aio.c > index 155f842..48e4fb0 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -208,6 +208,7 @@ static struct file *aio_private_file(struct kioctx > *ctx, loff_t nr_pages) > struct file *file; > struct path path; > struct inode *inode =3D alloc_anon_inode(aio_mnt->mnt_sb); > + > if (IS_ERR(inode)) > return ERR_CAST(inode); Your patch is white space damaged. Please resend in plain text without=20 HTML in a format that can be applied using git-am, and test that by sendi= ng=20 the email to yourself before reposting. -ben > @@ -269,6 +270,7 @@ __initcall(aio_setup); > static void put_aio_ring_file(struct kioctx *ctx) > { > struct file *aio_ring_file =3D ctx->aio_ring_file; > + > if (aio_ring_file) { > truncate_setsize(aio_ring_file->f_inode, 0); >=20 > @@ -293,6 +295,7 @@ static void aio_free_ring(struct kioctx *ctx) >=20 > for (i =3D 0; i < ctx->nr_pages; i++) { > struct page *page; > + > pr_debug("pid(%d) [%d] page->count=3D%d\n", current->pid, i, > page_count(ctx->ring_pages[i])); > page =3D ctx->ring_pages[i]; > @@ -475,6 +478,7 @@ static int aio_setup_ring(struct kioctx *ctx) >=20 > for (i =3D 0; i < nr_pages; i++) { > struct page *page; > + > page =3D find_or_create_page(file->f_inode->i_mapping, > i, GFP_HIGHUSER | __GFP_ZERO); > if (!page) > @@ -1352,6 +1356,7 @@ out: > SYSCALL_DEFINE1(io_destroy, aio_context_t, ctx) > { > struct kioctx *ioctx =3D lookup_ioctx(ctx); > + > if (likely(NULL !=3D ioctx)) { > struct ctx_rq_wait wait; > int ret; > --=20 > 2.1.4 --=20 "Thought is the essence of where you are now." -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org