From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:51061 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbbKQPdc (ORCPT ); Tue, 17 Nov 2015 10:33:32 -0500 Date: Tue, 17 Nov 2015 15:33:20 +0000 From: Al Viro To: Christoph Hellwig Cc: Chris Mason , "Darrick J. Wong" , xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org Subject: Re: clone ioctl return values Message-ID: <20151117153320.GU22011@ZenIV.linux.org.uk> References: <20151116120431.GA2860@infradead.org> <20151117002822.GA32467@birch.djwong.org> <20151117105433.GA18093@infradead.org> <20151117135745.GF17545@ret.masoncoding.com> <20151117152251.GA5392@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151117152251.GA5392@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 17, 2015 at 07:22:52AM -0800, Christoph Hellwig wrote: > Yes, I saw that. So so far I'd suggest something like the following > for btrfs: > > - return EBADFD for missing read/wite permissions Yowwwch... What the hell does that have to do with STREAMS? Or are you using EBADFD as "nobody uses that error value anyway, let's assign it whatever meaning we need"? Besides, that'll be confused with EBADF all the time. I strongly recommend against that.