From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, Chris Mason <clm@fb.com>,
xfs@oss.sgi.com, "Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: clone ioctl return values
Date: Tue, 17 Nov 2015 07:36:23 -0800 [thread overview]
Message-ID: <20151117153623.GA27322@infradead.org> (raw)
In-Reply-To: <20151117153320.GU22011@ZenIV.linux.org.uk>
On Tue, Nov 17, 2015 at 03:33:20PM +0000, Al Viro wrote:
> On Tue, Nov 17, 2015 at 07:22:52AM -0800, Christoph Hellwig wrote:
>
> > Yes, I saw that. So so far I'd suggest something like the following
> > for btrfs:
> >
> > - return EBADFD for missing read/wite permissions
>
> Yowwwch... What the hell does that have to do with STREAMS? Or are you
> using EBADFD as "nobody uses that error value anyway, let's assign it
> whatever meaning we need"?
>
> Besides, that'll be confused with EBADF all the time. I strongly
> recommend against that.
Yes, I meant EBADF. That's what we normally use for missing
FMODE_READ/WRITE or fget failures, so why would this call be different
from everything else?
next prev parent reply other threads:[~2015-11-17 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 12:04 clone ioctl return values Christoph Hellwig
2015-11-17 0:28 ` Darrick J. Wong
2015-11-17 10:54 ` Christoph Hellwig
2015-11-17 13:57 ` Chris Mason
2015-11-17 15:22 ` Christoph Hellwig
2015-11-17 15:33 ` Al Viro
2015-11-17 15:36 ` Christoph Hellwig [this message]
2015-11-17 18:42 ` Chris Mason
2015-11-18 3:01 ` Darrick J. Wong
2015-11-18 15:11 ` Christoph Hellwig
2015-11-17 15:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117153623.GA27322@infradead.org \
--to=hch@infradead.org \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).