From: Al Viro <viro@ZenIV.linux.org.uk>
To: Rajat Jain <rajatxjain@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
Davide Libenzi <davidel@xmailserver.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Anonymous inode cleanup?
Date: Wed, 18 Nov 2015 21:06:16 +0000 [thread overview]
Message-ID: <20151118210615.GE22011@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAA93t1o0Rupuz0c+8DiCXMNMcNLUEQkuAR5LKiz6omcq9_R55Q@mail.gmail.com>
On Wed, Nov 18, 2015 at 12:28:38PM -0800, Rajat Jain wrote:
> > _If_ you are returning them via a sucky API, the right sequence is
> > reserve the descriptor(s)
> > set the file(s) up
> > fill whatever structure you'll be using to report descriptors to
> > userland and copy it to userland memory
>
> If this step fails, what is the cleanup needed for "set the files up"
> anon_inode_getfile() step? is it fput()?
Yes.
next prev parent reply other threads:[~2015-11-18 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 5:43 Anonymous inode cleanup? Rajat Jain
2015-11-13 5:52 ` Mateusz Guzik
2015-11-13 6:31 ` Al Viro
2015-11-18 20:28 ` Rajat Jain
2015-11-18 21:06 ` Al Viro [this message]
2015-11-18 21:10 ` Rajat Jain
2015-11-18 21:24 ` Al Viro
2015-11-18 21:25 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118210615.GE22011@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davidel@xmailserver.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).