From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>,
linux-ext4@vger.kernel.org, tytso@mit.edu, xfs@oss.sgi.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix race aio-dio vs freeze_fs
Date: Tue, 24 Nov 2015 08:07:23 -0800 [thread overview]
Message-ID: <20151124160723.GA17466@infradead.org> (raw)
In-Reply-To: <20151124132421.GG25232@quack.suse.cz>
On Tue, Nov 24, 2015 at 02:24:21PM +0100, Jan Kara wrote:
> Well, this problem seems to suggest that we have the freeze protection for
> AIO writes wrong. We should call file_end_write() from aio_complete() and
> not from aio_run_iocb()... I believe XFS and other filesystems may have
> problems with this as well (CCed). Attached patch (so far only compile
> tested since my test machine is pondering on something else) should fix
> this.
Sounds like one way to do it, but we'd really want a vfs_* helper for
this so that it doesn't have to duplicated in other write_iter users
like the loop driver, which seems to be missing file
file_start_write/file_end_write entirely.
next prev parent reply other threads:[~2015-11-24 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448294568-20892-1-git-send-email-dmonakhov@openvz.org>
2015-11-24 13:24 ` [PATCH] ext4: fix race aio-dio vs freeze_fs Jan Kara
2015-11-24 16:07 ` Christoph Hellwig [this message]
2015-11-25 10:25 ` Jan Kara
2015-11-24 16:55 ` Dmitry Monakhov
2015-11-25 9:19 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124160723.GA17466@infradead.org \
--to=hch@infradead.org \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).