From: Christoph Hellwig <hch@lst.de>
To: David Disseldorp <ddiss@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, tao.peng@primarydata.com,
jeff.layton@primarydata.com, linux-fsdevel@vger.kernel.org,
linux-cifs@vger.kernel.org, Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 1/5] cifs: implement clone_file_range operation
Date: Mon, 30 Nov 2015 10:02:34 +0100 [thread overview]
Message-ID: <20151130090234.GB31810@lst.de> (raw)
In-Reply-To: <20151127114232.5b367b7b@g21.suse.de>
On Fri, Nov 27, 2015 at 11:42:32AM +0100, David Disseldorp wrote:
> I think that's about as close as we're going to get to clone semantics
> for cifs. It's also dispatched as a single request covering the full
> file - chunking only occurs for CIFS_IOC_COPYCHUNK_FILE based requests,
> which are implemented using FSCTL_SRV_COPYCHUNK_WRITE, and not (always)
> handled by the server as a COW clone.
Oh, I misread cifs_ioctl_clone - it does two entirely different things
based on the dup_extents parameter. It looked like it did both
of them in the dup_extents case. Re-reading the code it seems close
enough, although the client side samping of the file size seems a little
dangerous.
I'll wire it up for clone_file_range for the next respin, but I'm still
a little worried.
next prev parent reply other threads:[~2015-11-30 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 18:50 vfs: move btrfs clone ioctls to common code Christoph Hellwig
2015-11-26 18:50 ` [PATCH 1/5] cifs: implement clone_file_range operation Christoph Hellwig
2015-11-27 10:42 ` David Disseldorp
2015-11-30 9:02 ` Christoph Hellwig [this message]
2015-11-26 18:50 ` [PATCH 2/5] locks: new locks_mandatory_area calling convention Christoph Hellwig
2015-11-30 22:38 ` J. Bruce Fields
2015-12-01 7:37 ` Christoph Hellwig
2015-11-26 18:50 ` [PATCH 3/5] vfs: pull btrfs clone API to vfs layer Christoph Hellwig
2015-11-26 18:50 ` [PATCH 4/5] nfsd: Pass filehandle to nfs4_preprocess_stateid_op() Christoph Hellwig
2015-11-26 18:50 ` [PATCH 5/5] nfsd: implement the NFSv4.2 CLONE operation Christoph Hellwig
2015-11-30 22:56 ` vfs: move btrfs clone ioctls to common code J. Bruce Fields
2015-12-01 17:09 ` Chris Mason
2015-12-01 22:48 ` Steve French
2015-12-02 7:27 ` Christoph Hellwig
2015-12-02 17:40 ` Steve French
2015-12-03 10:30 ` Christoph Hellwig
2015-12-03 19:28 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130090234.GB31810@lst.de \
--to=hch@lst.de \
--cc=ddiss@suse.de \
--cc=jeff.layton@primarydata.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=tao.peng@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).