* sys_copy_file_range tests
@ 2015-12-01 18:10 Christoph Hellwig
2015-12-03 20:43 ` Anna Schumaker
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2015-12-01 18:10 UTC (permalink / raw)
To: Anna.Schumaker; +Cc: fstests, linux-fsdevel
Hi Anna,
I recently looked into allowing sys_copy_file_range to use the
clone_file_range operation so that file systems don't have to support
two methods if they only support clone-like features, and one thing
I noticed is that unlike for clone there are no tests for
clone_file_range in xfstests, and I couldn't find a testsuite anywhere
else either. Do you have any good tests available to verify the
implementation?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: sys_copy_file_range tests
2015-12-01 18:10 sys_copy_file_range tests Christoph Hellwig
@ 2015-12-03 20:43 ` Anna Schumaker
2015-12-04 8:28 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Anna Schumaker @ 2015-12-03 20:43 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: fstests, linux-fsdevel
Hi Christoph,
On 12/01/2015 01:10 PM, Christoph Hellwig wrote:
> Hi Anna,
>
> I recently looked into allowing sys_copy_file_range to use the
> clone_file_range operation so that file systems don't have to support
> two methods if they only support clone-like features, and one thing
> I noticed is that unlike for clone there are no tests for
> clone_file_range in xfstests, and I couldn't find a testsuite anywhere
> else either. Do you have any good tests available to verify the
> implementation?
>
Sadly, I don't have very good tests and I was mostly using the example program from the man page under various filesystems and setups. At LPC, Darrick made it sound like he was going to work on adding vfs_copy_file_range() tests to xfstests but that probably turned into the reflink/dedupe ioctl tests.
I can try to find time to write something for xfstests if that would be useful!
Anna
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: sys_copy_file_range tests
2015-12-03 20:43 ` Anna Schumaker
@ 2015-12-04 8:28 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2015-12-04 8:28 UTC (permalink / raw)
To: Anna Schumaker; +Cc: fstests, linux-fsdevel
On Thu, Dec 03, 2015 at 03:43:32PM -0500, Anna Schumaker wrote:
> Sadly, I don't have very good tests and I was mostly using the example
> program from the man page under various filesystems and setups. At LPC,
> Darrick made it sound like he was going to work on adding
> vfs_copy_file_range() tests to xfstests but that probably turned into
> the reflink/dedupe ioctl tests.
>
> I can try to find time to write something for xfstests if that would
> be useful!
Yes, Darrick wrote a lot of clone tests. Some of the aren't applicable
to a pure copy, but I looking over them anc checking what should apply
would be very useful!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-04 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-01 18:10 sys_copy_file_range tests Christoph Hellwig
2015-12-03 20:43 ` Anna Schumaker
2015-12-04 8:28 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).