From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Jan Kara <jack@suse.cz>,
stable@vger.kernel.org, Steven Whitehouse <swhiteho@redhat.com>,
Avi Kivity <avi@scylladb.com>, Jens Axboe <axboe@fb.com>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
torvalds@linux-foundation.org
Subject: Re: v4.4-rc4 regression with direct-io
Date: Wed, 9 Dec 2015 12:49:02 +0100 [thread overview]
Message-ID: <20151209114902.GD3137@quack.suse.cz> (raw)
In-Reply-To: <20151208215109.GR20997@ZenIV.linux.org.uk>
On Tue 08-12-15 21:51:09, Al Viro wrote:
> On Tue, Dec 08, 2015 at 02:39:02PM -0700, Ross Zwisler wrote:
> > Hey Jan,
> >
> > In my test setup this commit:
> >
> > 74cedf9b6c60 ("direct-io: Fix negative return from dio read beyond eof")
> >
> > causes a regression with XFS and the test generic/113. The test used to
> > pass, but with the above mentioned commit it just hangs indefinitely.
> >
> > This commit went in between v4.4-rc3 and v4.4-rc4, and it looks like it was
> > marked for stable?
>
> See the tip of vfs.git#for-linus for fix...
Ah, thanks for fixing this up! I'm just wondering how the test program I
was using could have passed because pread() I'm doing there must have
returned ENOMEM... Argh, I see. I have tested the problem with ext4 which
uses DIO_LOCKING mode and in that case 'retval' gets overwritten to 0 by
filemap_write_and_wait() call :-|.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2015-12-09 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 21:39 v4.4-rc4 regression with direct-io Ross Zwisler
2015-12-08 21:51 ` Al Viro
2015-12-08 23:14 ` Ross Zwisler
2015-12-09 11:49 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209114902.GD3137@quack.suse.cz \
--to=jack@suse.cz \
--cc=avi@scylladb.com \
--cc=axboe@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=swhiteho@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).