* [PATCH] nwflash: use no_seek_end_llseek_size
@ 2015-12-09 16:33 Arnd Bergmann
2015-12-09 18:04 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-09 16:33 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-arm-kernel, linux-kernel
The recently introduced no_seek_end_llseek was wrong, it should
be no_seek_end_llseek_size:
drivers/char/nwflash.c: In function 'flash_llseek':
drivers/char/nwflash.c:280:8: error: too many arguments to function 'no_seek_end_llseek'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 00c1b53c0e61 ("new helpers: no_seek_end_llseek{,_size}()")
diff --git a/drivers/char/nwflash.c b/drivers/char/nwflash.c
index 362fb1e230e3..dbe598de9b74 100644
--- a/drivers/char/nwflash.c
+++ b/drivers/char/nwflash.c
@@ -277,7 +277,7 @@ static loff_t flash_llseek(struct file *file, loff_t offset, int orig)
printk(KERN_DEBUG "flash_llseek: offset=0x%X, orig=0x%X.\n",
(unsigned int) offset, orig);
- ret = no_seek_end_llseek(file, offset, orig, gbFlashSize);
+ ret = no_seek_end_llseek_size(file, offset, orig, gbFlashSize);
mutex_unlock(&flash_mutex);
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nwflash: use no_seek_end_llseek_size
2015-12-09 16:33 [PATCH] nwflash: use no_seek_end_llseek_size Arnd Bergmann
@ 2015-12-09 18:04 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2015-12-09 18:04 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-fsdevel, linux-arm-kernel, linux-kernel
On Wed, Dec 09, 2015 at 05:33:45PM +0100, Arnd Bergmann wrote:
> The recently introduced no_seek_end_llseek was wrong, it should
> be no_seek_end_llseek_size:
>
> drivers/char/nwflash.c: In function 'flash_llseek':
> drivers/char/nwflash.c:280:8: error: too many arguments to function 'no_seek_end_llseek'
Folded and pushed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-09 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-09 16:33 [PATCH] nwflash: use no_seek_end_llseek_size Arnd Bergmann
2015-12-09 18:04 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).