From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 10 Dec 2015 04:14:24 +0000 From: Al Viro To: Kees Cook Cc: Andrew Morton , Jan Kara , yalin wang , Willy Tarreau , "Eric W. Biederman" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] fs: clear file privilege bits when mmap writing Message-ID: <20151210041424.GD20997@ZenIV.linux.org.uk> References: <20151209225148.GA14794@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151209225148.GA14794@www.outflux.net> Sender: owner-linux-mm@kvack.org List-ID: On Wed, Dec 09, 2015 at 02:51:48PM -0800, Kees Cook wrote: > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3aa514254161..409bd7047e7e 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -872,6 +872,7 @@ struct file { > struct list_head f_tfile_llink; > #endif /* #ifdef CONFIG_EPOLL */ > struct address_space *f_mapping; > + bool f_remove_privs; NAK. If anything, such things belong in ->f_flags. _If_ this is worth doing at all, that is. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org