From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 10 Dec 2015 19:33:51 +0000 From: Al Viro To: Willy Tarreau Cc: Kees Cook , Andrew Morton , Jan Kara , yalin wang , "Eric W. Biederman" , "linux-fsdevel@vger.kernel.org" , Linux-MM , LKML Subject: Re: [PATCH v5] fs: clear file privilege bits when mmap writing Message-ID: <20151210193351.GE20997@ZenIV.linux.org.uk> References: <20151209225148.GA14794@www.outflux.net> <20151210070635.GC31922@1wt.eu> <20151210181611.GB32083@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151210181611.GB32083@1wt.eu> Sender: owner-linux-mm@kvack.org List-ID: On Thu, Dec 10, 2015 at 07:16:11PM +0100, Willy Tarreau wrote: > > Is f_flags safe to write like this without holding a lock? > > Unfortunately I have no idea. I've seen places where it's written without > taking a lock such as in blkdev_open() and I don't think that this one is > called with a lock held. In any ->open() we obviously have nobody else able to find that struct file, let alone modify it, so there the damn thing is essentially caller-private and no locking is needed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org