From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 10 Dec 2015 20:27:49 +0000 From: Al Viro To: Kees Cook Cc: Willy Tarreau , Andrew Morton , Jan Kara , yalin wang , "Eric W. Biederman" , "linux-fsdevel@vger.kernel.org" , Linux-MM , LKML Subject: Re: [PATCH v5] fs: clear file privilege bits when mmap writing Message-ID: <20151210202749.GF20997@ZenIV.linux.org.uk> References: <20151209225148.GA14794@www.outflux.net> <20151210070635.GC31922@1wt.eu> <20151210181611.GB32083@1wt.eu> <20151210193351.GE20997@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: On Thu, Dec 10, 2015 at 11:47:18AM -0800, Kees Cook wrote: > In open, sure, but what about under mm/memory.c where we're trying to > twiddle it from vma->file->f_flags as in my patch? That seemed like it > would want atomic safety. Sigh... Again, I'm not at all convinced that this is the right approach, but generally you need ->f_lock. And in situations where the bit can go only off->on, check it lockless, skip the whole thing entirely if it's already set and grab the spinlock otherwise. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org