From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhihui Zhang <zzhsuny@gmail.com>
Cc: clm@fb.com, tytso@mit.edu, swhiteho@redhat.com, mfasheh@suse.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Remove I_WILL_FREE
Date: Sat, 2 Jan 2016 02:31:06 +0000 [thread overview]
Message-ID: <20160102023105.GH9938@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1451699526-28608-1-git-send-email-zzhsuny@gmail.com>
On Fri, Jan 01, 2016 at 08:52:06PM -0500, Zhihui Zhang wrote:
> I_WILL_FREE does not really add any new functionality over I_FREEING.
> If I_WILL_FREE is set, it will be replaced by I_FREEING under the inode
> lock. And they always appear in the same if statement.
Do they? Consider
fs/fs-writeback.c:351: if (unlikely(inode->i_state & I_FREEING))
fs/fs-writeback.c:472: if (inode->i_state & (I_WB_SWITCH | I_FREEING) ||
fs/fs-writeback.c:1161: if (inode->i_state & I_FREEING)
fs/fs-writeback.c:2049: if (inode->i_state & I_FREEING)
for a few counterexamples...
next prev parent reply other threads:[~2016-01-02 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 1:52 [PATCH] Remove I_WILL_FREE Zhihui Zhang
2016-01-02 2:31 ` Al Viro [this message]
2016-01-02 3:12 ` Zhihui Zhang
2016-01-02 5:18 ` Al Viro
2016-01-02 15:54 ` Zhihui Zhang
2016-01-05 17:08 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160102023105.GH9938@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=clm@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
--cc=zzhsuny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).