From: Andrew Morton <akpm@linux-foundation.org>
To: <luca.risolia@studio.unibo.it>
Cc: "Jader H. Silva" <jaderhs5@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fuse: implement cuse mmap
Date: Tue, 5 Jan 2016 13:19:24 -0800 [thread overview]
Message-ID: <20160105131924.d871547c34404b7889549626@linux-foundation.org> (raw)
In-Reply-To: <568C25BC.2040609@studio.unibo.it>
On Tue, 5 Jan 2016 21:21:16 +0100 Luca Risolia <luca.risolia@studio.unibo.it> wrote:
> I was wondering if there's a chance to have this patch merged anytime
> soon. Note that FUSE maintainer left off sometime ago and there's no one
> taking care of kernel patches at the moment.
>
> Please let Jader and me know if there are any problems.
I didn't know that FUSE maintainership had altered.
At -rc8 isn't a convenient time - please resend after 4.5-rc1. I of
course *could* merge the patch now and hold it off for the 4.6 merge
window, but...
Please write a much more complete changelog. Much. What are the
objectives, why do we need this feature. How did you choose to
implement the feature. Are there alternative ways of implementing it
and if so, why did you choose this way, etc.
Also, the code is poorly commented. Please fix that, concentrating
less on *what* the code is doing and more on *why* it is doing it.
Tell the reader what you're trying to achieve. Tell the reader those
things which aren't discernible from the code itself.
Documenting the data structures is particularly important. In kernel
code, if that is done well enough then the code itself tends to become
rather obvious. Like, what's going on with this vm_original_ops thing?
hm, that's a bit of a head-scratcher at present.
Thanks.
prev parent reply other threads:[~2016-01-05 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 19:40 [PATCH] fuse: implement cuse mmap Jader H. Silva
2015-12-16 19:50 ` Luca Risolia
2015-12-16 19:54 ` kbuild test robot
2016-01-05 20:21 ` Luca Risolia
2016-01-05 21:19 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105131924.d871547c34404b7889549626@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jaderhs5@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.risolia@studio.unibo.it \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).