From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 03/13] udf: don't duplicate page_symlink_inode_operations
Date: Tue, 5 Jan 2016 17:27:10 +0100 [thread overview]
Message-ID: <20160105162710.GB18604@quack.suse.cz> (raw)
In-Reply-To: <1451630301-30618-3-git-send-email-viro@ZenIV.linux.org.uk>
On Fri 01-01-16 06:38:11, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Looks good. I guess it's more convenient for you to take this change
through your tree so:
Acked-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/udf/inode.c | 2 +-
> fs/udf/namei.c | 7 +------
> fs/udf/udfdecl.h | 1 -
> 3 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 8d0b3ad..8675c2b 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1540,7 +1540,7 @@ reread:
> break;
> case ICBTAG_FILE_TYPE_SYMLINK:
> inode->i_data.a_ops = &udf_symlink_aops;
> - inode->i_op = &udf_symlink_inode_operations;
> + inode->i_op = &page_symlink_inode_operations;
> inode->i_mode = S_IFLNK | S_IRWXUGO;
> break;
> case ICBTAG_FILE_TYPE_MAIN:
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index c97b5a8..d0e6de1 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -921,7 +921,7 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry,
> }
>
> inode->i_data.a_ops = &udf_symlink_aops;
> - inode->i_op = &udf_symlink_inode_operations;
> + inode->i_op = &page_symlink_inode_operations;
>
> if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) {
> struct kernel_lb_addr eloc;
> @@ -1344,8 +1344,3 @@ const struct inode_operations udf_dir_inode_operations = {
> .rename = udf_rename,
> .tmpfile = udf_tmpfile,
> };
> -const struct inode_operations udf_symlink_inode_operations = {
> - .readlink = generic_readlink,
> - .follow_link = page_follow_link_light,
> - .put_link = page_put_link,
> -};
> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
> index 47bb3f5..ce169b4 100644
> --- a/fs/udf/udfdecl.h
> +++ b/fs/udf/udfdecl.h
> @@ -85,7 +85,6 @@ extern const struct inode_operations udf_dir_inode_operations;
> extern const struct file_operations udf_dir_operations;
> extern const struct inode_operations udf_file_inode_operations;
> extern const struct file_operations udf_file_operations;
> -extern const struct inode_operations udf_symlink_inode_operations;
> extern const struct address_space_operations udf_aops;
> extern const struct address_space_operations udf_adinicb_aops;
> extern const struct address_space_operations udf_symlink_aops;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-01-05 16:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 6:36 [RFC] ->get_link(), ->put_link() and cookies Al Viro
2016-01-01 6:38 ` [PATCH 01/13] switch befs long symlinks to page_symlink_operations Al Viro
2016-01-01 6:38 ` [PATCH 02/13] logfs: don't duplicate page_symlink_inode_operations Al Viro
2016-01-01 6:38 ` [PATCH 03/13] udf: " Al Viro
2016-01-05 16:27 ` Jan Kara [this message]
2016-01-01 6:38 ` [PATCH 04/13] ufs: get rid of ->setattr() for symlinks Al Viro
2016-01-01 6:38 ` [PATCH 05/13] namei: page_getlink() and page_follow_link_light() are the same thing Al Viro
2016-01-01 6:38 ` [PATCH 06/13] don't put symlink bodies in pagecache into highmem Al Viro
2016-01-01 6:38 ` [PATCH 07/13] replace ->follow_link() with new method that could stay in RCU mode Al Viro
2016-01-01 6:38 ` [PATCH 08/13] teach page_get_link() to work " Al Viro
2016-01-01 6:38 ` [PATCH 09/13] teach shmem_get_link() " Al Viro
2016-01-01 6:38 ` [PATCH 10/13] teach proc_self_get_link()/proc_thread_self_get_link() " Al Viro
2016-01-01 6:38 ` [PATCH 11/13] teach nfs_get_link() " Al Viro
2016-01-01 6:38 ` [PATCH 12/13] kill free_page_put_link() Al Viro
2016-01-01 6:38 ` [PATCH 13/13] switch ->get_link() to delayed_call, kill ->put_link() Al Viro
2016-01-03 19:53 ` [RFC] ->get_link(), ->put_link() and cookies Linus Torvalds
2016-01-03 20:21 ` Al Viro
2016-01-03 20:41 ` Linus Torvalds
2016-01-03 21:40 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105162710.GB18604@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).