From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:41744 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752319AbcAFOuM (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 6 Jan 2016 09:50:12 -0500
Date: Wed, 6 Jan 2016 14:50:08 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jann Horn <jann@thejh.net>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Kees Cook <keescook@google.com>,
	Andy Lutomirski <luto@amacapital.net>, security@kernel.org
Subject: Re: [PATCH 1/2] compat_ioctl: don't look up the fd twice
Message-ID: <20160106145008.GU9938@ZenIV.linux.org.uk>
References: <1452014850-19354-1-git-send-email-jann@thejh.net>
 <CA+55aFzX9Gm=t=0HSnMxDeZmHkiZDMRKrBBvBw4CwPK1EbNbUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFzX9Gm=t=0HSnMxDeZmHkiZDMRKrBBvBw4CwPK1EbNbUQ@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jan 05, 2016 at 11:33:53AM -0800, Linus Torvalds wrote:
> On Jan 5, 2016 9:27 AM, "Jann Horn" <jann@thejh.net> wrote:
> >
> > This change mitigates potential security issues by
> > preventing a race that permits invocation of
> > unlocked_ioctl handlers under KERNEL_DS through compat
> > code even if a corresponding compat_ioctl handler exists.
> 
> Yeah, these two patches are much more legible now. Thanks.
> 
> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> Al, I'm assuming I'll get these through the vfs tree during the 4.5 merge
> window. Correct?

I'll need to finish reviewing, but yes, that's 4.5 vfs.git fodder.
So far it looks sane...