linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	Dmitry Monakhov <dmonakhov@openvz.org>
Subject: Re: [PATCH] aio: Fix freeze protection of aio writes
Date: Thu, 7 Jan 2016 10:08:25 -0500	[thread overview]
Message-ID: <20160107150825.GK4439@kvack.org> (raw)
In-Reply-To: <20160107150705.GJ4439@kvack.org>

On Thu, Jan 07, 2016 at 10:07:05AM -0500, Benjamin LaHaise wrote:
> On Thu, Jan 07, 2016 at 04:03:04PM +0100, Jan Kara wrote:
> > Fix the problem by dropping freeze protection only once IO is completed
> > in aio_complete().
> 
> Why isn't this code placed in file_start_write() and file_end_write()?  
> That makes more sense to me than sprinkling it in the aio code.

And yes, the file_end_write() call should be moved to aio completion as 
well.

		-ben
-- 
"Thought is the essence of where you are now."

  reply	other threads:[~2016-01-07 15:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 15:03 [PATCH] aio: Fix freeze protection of aio writes Jan Kara
2016-01-07 15:07 ` Benjamin LaHaise
2016-01-07 15:08   ` Benjamin LaHaise [this message]
2016-01-07 15:15   ` Jan Kara
2016-01-07 16:24     ` Benjamin LaHaise
  -- strict thread matches above, loose matches on Subject: below --
2015-11-26 17:10 Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160107150825.GK4439@kvack.org \
    --to=bcrl@kvack.org \
    --cc=dmonakhov@openvz.org \
    --cc=jack@suse.cz \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).