From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from kanga.kvack.org ([205.233.56.17]:60712 "EHLO kanga.kvack.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752757AbcAGPIZ (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 7 Jan 2016 10:08:25 -0500
Date: Thu, 7 Jan 2016 10:08:25 -0500
From: Benjamin LaHaise <bcrl@kvack.org>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, linux-aio@kvack.org,
	linux-fsdevel@vger.kernel.org,
	Dmitry Monakhov <dmonakhov@openvz.org>
Subject: Re: [PATCH] aio: Fix freeze protection of aio writes
Message-ID: <20160107150825.GK4439@kvack.org>
References: <1452178984-17540-1-git-send-email-jack@suse.cz> <20160107150705.GJ4439@kvack.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160107150705.GJ4439@kvack.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jan 07, 2016 at 10:07:05AM -0500, Benjamin LaHaise wrote:
> On Thu, Jan 07, 2016 at 04:03:04PM +0100, Jan Kara wrote:
> > Fix the problem by dropping freeze protection only once IO is completed
> > in aio_complete().
> 
> Why isn't this code placed in file_start_write() and file_end_write()?  
> That makes more sense to me than sprinkling it in the aio code.

And yes, the file_end_write() call should be moved to aio completion as 
well.

		-ben
-- 
"Thought is the essence of where you are now."