From: Benjamin LaHaise <bcrl@kvack.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-aio@kvack.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [GIT PULL] aio: a couple of fixes for 4.4
Date: Sat, 9 Jan 2016 18:00:36 -0500 [thread overview]
Message-ID: <20160109230036.GA12345@kvack.org> (raw)
In-Reply-To: <CA+55aFzLcEkdiE9cmexdTgmQxtfz=x4_idK_QmEytiHxGaj+gQ@mail.gmail.com>
On Sat, Jan 09, 2016 at 02:43:44PM -0800, Linus Torvalds wrote:
> On Sat, Jan 9, 2016 at 2:08 PM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> >
> > Please consider pulling the following changes to fix a couple of issues
> > reported by Dmitry from git://git.kvack.org/~bcrl/aio-fixes.git .
>
> No. This is much too late for this kind of hackery. That second patch
> in particular is both subtle and ugly, and is messing with lockdep.
I wasn't particularly fond of how Jan implemented that. Any ideas on a
better way to avoid lockdep complaining about this? My initial feedback
to Jan was exactly that this should be handled within the file_start_write()
and file_end_write() APIs -- AIO really shouldn't need to be mucking in what
ought to be hidden behind that API.
> No way will I take something like this the last fay before a release.
>
> It's not even a regression, nor did you send me anything at all for
> this release. Trying to sneak something in just before 4.4 is not ok.
Okay, no worries.
-ben
> Linus
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2016-01-09 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 22:08 [GIT PULL] aio: a couple of fixes for 4.4 Benjamin LaHaise
2016-01-09 22:43 ` Linus Torvalds
2016-01-09 23:00 ` Benjamin LaHaise [this message]
2016-01-11 16:59 ` Jan Kara
2016-01-09 23:08 ` Al Viro
2016-01-10 4:36 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109230036.GA12345@kvack.org \
--to=bcrl@kvack.org \
--cc=dvyukov@google.com \
--cc=jack@suse.cz \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).