From: Dave Chinner <david@fromorbit.com>
To: Fan Li <fanofcode.li@samsung.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: fix bugs for __generic_block_fiemap()
Date: Mon, 11 Jan 2016 09:21:53 +1100 [thread overview]
Message-ID: <20160110222153.GC10456@dastard> (raw)
In-Reply-To: <001401d14aba$dfe6c370$9fb44a50$@samsung.com>
On Sat, Jan 09, 2016 at 04:50:34PM +0800, Fan Li wrote:
> Fix 3 bugs:
> 1. If there are more than two blocks of holes after the last
> extent of file, it would fail to add FIEMAP_EXTENT_LAST
> to the last extent.
> 2. len hasn't been updated correctly, if len > isize and
> start > 0.
> 3. If len is less than one block, it will be extended to
> one block. If start + len exceeds the boundary of the
> original block because of the extension, one extra block
> will be returned.
>
> And simplify the codes of __generic_block_fiemap() as well.
One bug fix/change per patch, please, so they can be easily
reviewed.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-01-10 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 8:50 [PATCH] fs: fix bugs for __generic_block_fiemap() Fan Li
2016-01-10 22:21 ` Dave Chinner [this message]
2016-01-11 6:41 ` Fan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110222153.GC10456@dastard \
--to=david@fromorbit.com \
--cc=fanofcode.li@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).