From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:52108 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259AbcAJWV4 (ORCPT ); Sun, 10 Jan 2016 17:21:56 -0500 Date: Mon, 11 Jan 2016 09:21:53 +1100 From: Dave Chinner To: Fan Li Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: fix bugs for __generic_block_fiemap() Message-ID: <20160110222153.GC10456@dastard> References: <001401d14aba$dfe6c370$9fb44a50$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001401d14aba$dfe6c370$9fb44a50$@samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Jan 09, 2016 at 04:50:34PM +0800, Fan Li wrote: > Fix 3 bugs: > 1. If there are more than two blocks of holes after the last > extent of file, it would fail to add FIEMAP_EXTENT_LAST > to the last extent. > 2. len hasn't been updated correctly, if len > isize and > start > 0. > 3. If len is less than one block, it will be extended to > one block. If start + len exceeds the boundary of the > original block because of the extension, one extra block > will be returned. > > And simplify the codes of __generic_block_fiemap() as well. One bug fix/change per patch, please, so they can be easily reviewed. Cheers, Dave. -- Dave Chinner david@fromorbit.com