From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Sat, 16 Jan 2016 13:44:58 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] vfs.git regression fix
Message-ID: <20160116134458.GK17997@ZenIV.linux.org.uk>
References: <20160115201810.GF17997@ZenIV.linux.org.uk>
 <CA+55aFwrubi+s4dF5_JqODkNGd-k-8+bkFVUaBvPPLD55Sx1Nw@mail.gmail.com>
 <20160115210046.GG17997@ZenIV.linux.org.uk>
 <CA+55aFwK4sNh1+iUZJcsvdMRJ7cfi9_THGcHR6Cj5KrfF1wh=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFwK4sNh1+iUZJcsvdMRJ7cfi9_THGcHR6Cj5KrfF1wh=g@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jan 15, 2016 at 01:08:44PM -0800, Linus Torvalds wrote:
> On Fri, Jan 15, 2016 at 1:00 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Buggy scripts, actually.  The thing that generates them takes a branch
> > name as argument; turns out that it (pretty much by accident) treats the
> > missing argument as HEAD.  Which tends to give reasonable diffstat and
> > shortlog, so I hadn't spotted the missing check until now.
> 
> You could try "git request-pull". It _used_ to have somewhat similar
> issues, especially when the local branch had not made it to the remote
> point yet, but it should be good now. It actually warns if the remote
> name you give doesn't contain what the local branch contanis etc.

Having checked how git request-pull reacts to missing branch argument...
Very similar bug there - it gives stats for HEAD and URI with no branch
name.  Might've been fixed in later versions (it's 2.1.4 here - debian-stable)

FWIW, the main inconvenience with git request-pull is that it still needs
s/gitolite@ra.kernel.org:/git:\/\/git.kernel.org/ postprocessing.  It mimics
the git push, but the remote you are pushing to probably won't be usable for
pulling by others.  Looks like it would be useful to have something like
	pull_url = git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git
to go with
	url = gitolite@ra.kernel.org:/pub/scm/linux/kernel/git/viro/vfs.git
in .git/config, settable by something in git remote.  OTOH, it's possible to
emulate by setting an extra remote and using git push vfs <...> for pushes,
while doing git request-pull origin vfs-pull <...> for pull requests...