From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:41976 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752723AbcAPVWx (ORCPT ); Sat, 16 Jan 2016 16:22:53 -0500 Date: Sat, 16 Jan 2016 16:22:51 -0500 From: Theodore Ts'o To: Dave Chinner Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, ext4@vger.kernel.org Subject: Re: [PATCH 3/3] xfs: introduce per-inode DAX enablement Message-ID: <20160116212251.GC26427@thunk.org> References: <1451886892-15548-1-git-send-email-david@fromorbit.com> <1451886892-15548-4-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451886892-15548-4-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jan 04, 2016 at 04:54:52PM +1100, Dave Chinner wrote: > From: Dave Chinner > > Rather than just being able to turn DAX on and off via a mount > option, some applications may only want to enable DAX for certain > performance critical files in a filesystem. > > This patch introduces a new inode flag to enable DAX in the v3 inode > di_flags2 field. It adds support for setting and clearing flags in > the di_flags2 field via the XFS_IOC_FSSETXATTR ioctl, and sets the > S_DAX inode flag appropriately when it is seen. > > When this flag is set on a directory, it acts as an "inherit flag". > That is, inodes created in the directory will automatically inherit > the on-disk inode DAX flag, enabling administrators to set up > directory heirarchies that automatically use DAX. Setting this flag > on an empty root directory will make the entire filesystem use DAX > by default. > > Signed-off-by: Dave Chinner Looks good to me. Reviewed-by: Theodore Ts'o - Ted