From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:41175 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755473AbcA1VXp (ORCPT ); Thu, 28 Jan 2016 16:23:45 -0500 Date: Fri, 29 Jan 2016 08:23:14 +1100 From: Dave Chinner To: Matthew Wilcox Cc: Jan Kara , Ross Zwisler , Matthew Wilcox , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] dax: Giant hack Message-ID: <20160128212314.GQ6033@dastard> References: <1453867708-3999-1-git-send-email-matthew.r.wilcox@intel.com> <1453867708-3999-3-git-send-email-matthew.r.wilcox@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453867708-3999-3-git-send-email-matthew.r.wilcox@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jan 26, 2016 at 11:08:28PM -0500, Matthew Wilcox wrote: > From: Matthew Wilcox > > This glop of impossible-to-review code implements a number of ideas that > need to be separated out. > > - Eliminate vm_ops->huge_fault. The core calls ->fault instead and callers > who set VM_HUGEPAGE should be prepared to deal with FAULT_FLAG_SIZE_PMD > (and larger) > - Switch back to calling ->page_mkwrite instead of ->pfn_mkwrite. DAX now > always has a page to lock, and no other imlementations of ->pfn_mkwrite > exist. > - dax_mkwrite splits out from dax_fault. dax_fault will now never call > get_block() to allocate a block; only to see if a block has been allocated. > dax_mkwrite will always attempt to allocate a block. > - Filesystems now take their DAX allocation mutex in exclusive/write mode > when calling dax_mkwrite. > - Split out dax_insert_pmd_mapping() from dax_pmd_fault and share it with > the new dax_pmd_mkwrite > - Change dax_pmd_write to take a vm_fault argument like the rest of the > family of functions. > > Signed-off-by: Matthew Wilcox I haven't looked really closely at the patch itself, but I like the direction you're taking here. Cheers, Dave. -- Dave Chinner david@fromorbit.com