From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mga01.intel.com ([192.55.52.88]:21765 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752330AbcA2Obi (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 29 Jan 2016 09:31:38 -0500
Date: Fri, 29 Jan 2016 09:31:35 -0500
From: Matthew Wilcox <willy@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
	Dave Chinner <david@fromorbit.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm,fs,dax: Change ->pmd_fault to ->huge_fault
Message-ID: <20160129143135.GU2948@linux.intel.com>
References: <1453867708-3999-1-git-send-email-matthew.r.wilcox@intel.com>
 <1453867708-3999-2-git-send-email-matthew.r.wilcox@intel.com>
 <20160128121710.GF7726@quack.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160128121710.GF7726@quack.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jan 28, 2016 at 01:17:10PM +0100, Jan Kara wrote:
> >  {
> > +	struct vm_fault vmf = {
> > +		.virtual_address = (void __user *)address,
> > +		.flags = flags | FAULT_FLAG_SIZE_PMD,
> > +		.pmd = pmd,
> > +	};
> > +
> 
> I think we should fill in also the vmf.gfp_mask and vmf.pgoff fields. I
> know they are not currently used but it would be a nasty surprise if
> someone tried to use them in the future...

Hmm.  We probably should try to use gfp_mask and pgoff.  I'll note those for
a future patch series, and I'll initialise them now.  Thanks!