From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:52888 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751342AbcBBCYl (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 1 Feb 2016 21:24:41 -0500
Date: Tue, 2 Feb 2016 02:24:36 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Insu Yun <wuninsu@gmail.com>
Cc: akpm@linux-foundation.org, fabf@skynet.be, osandov@osandov.com,
	geert@linux-m68k.org, tsgatesv@gmail.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
	changwoo@gatech.edu
Subject: Re: [PATCH] affs: add kunmap in error path
Message-ID: <20160202022436.GM17997@ZenIV.linux.org.uk>
References: <1454378117-14999-1-git-send-email-wuninsu@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454378117-14999-1-git-send-email-wuninsu@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Feb 01, 2016 at 08:55:17PM -0500, Insu Yun wrote:
> When error occurs, it needs to unmap page.

Point, but...  I'm not sure there's any point in keeping it mapped all
along.  After all, what we are doing is a bunch of memcpy() into the
parts of page, so kmap_atomic()/kunmap_atomic() just around memcpy
would do just fine.