From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:61512 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbcBEBGm (ORCPT ); Thu, 4 Feb 2016 20:06:42 -0500 Date: Fri, 5 Feb 2016 12:05:19 +1100 From: Dave Chinner To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Mark Fasheh , Joel Becker , xfs@oss.sgi.com Subject: Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota Message-ID: <20160205010519.GJ459@dastard> References: <1454596087-6814-1-git-send-email-jack@suse.cz> <1454596087-6814-2-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454596087-6814-2-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Feb 04, 2016 at 03:28:05PM +0100, Jan Kara wrote: > Add infrastructure for supporting get_nextdqblk() callback for VFS > quotas. Translate the operation into a callback to appropriate > filesystem and consequently to quota format callback. > > Signed-off-by: Jan Kara I'm a little confused here. What patchset is this dependent on? i.e. what introduces the ->get_nextdqblk method? The patches I currently have in my XFS working tree introduce this (quota: add new quotactl Q_XGETNEXTQUOTA) and everythign else is dependent on this. I looked a coupl eof days ago and I wasnt' able to find this in your tree. I'd much prefer that one of us publish a stable branch with just the quotactl() infrastructure (i.e. commands and bits up to the ->get_nextdqblk() callback) that we can then both base the different subsystem implementations off, rather than one of us having to pull in a whole tree of changes just to get the one commit we need... Cheers, Dave. -- Dave Chinner david@fromorbit.com