From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 2/3] xfs: don't use ioends for direct write completions
Date: Sat, 6 Feb 2016 09:36:26 +1100 [thread overview]
Message-ID: <20160205223626.GN459@dastard> (raw)
In-Reply-To: <20160205215718.GM20038@birch.djwong.org>
On Fri, Feb 05, 2016 at 01:57:18PM -0800, Darrick J. Wong wrote:
> On Wed, Feb 03, 2016 at 07:40:15PM +0100, Christoph Hellwig wrote:
> > - struct kiocb *iocb,
> > - loff_t offset,
> > - ssize_t size,
> > - void *private)
> > -{
> > - struct inode *inode = file_inode(iocb->ki_filp);
> > - struct xfs_ioend *ioend = private;
> > + trace_xfs_end_io_direct_write_append(ip, offset, size);
> >
> > - if (size <= 0)
> > - return 0;
> > -
> > - trace_xfs_gbmap_direct_endio(XFS_I(inode), offset, size,
> > - ioend ? ioend->io_type : 0, NULL);
> > -
> > - if (!ioend) {
> > - ASSERT(offset + size <= i_size_read(inode));
> > - return 0;
> > + tp = xfs_trans_alloc(mp, XFS_TRANS_FSYNC_TS);
> > + error = xfs_trans_reserve(tp, &M_RES(mp)->tr_fsyncts, 0, 0);
> > + if (error) {
> > + xfs_trans_cancel(tp);
> > + return error;
> > + }
> > + error = xfs_setfilesize(ip, tp, offset, size);
>
> Don't we need a xfs_trans_commit() here?
No, xfs_setfilesize() does that.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-02-05 22:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 18:40 vfs/xfs: directio updates to ease COW handling V2 Christoph Hellwig
2016-02-03 18:40 ` [PATCH 1/3] direct-io: always call ->end_io if non-NULL Christoph Hellwig
2016-02-03 19:55 ` Darrick J. Wong
2016-02-04 7:14 ` Christoph Hellwig
2016-02-04 8:17 ` Darrick J. Wong
2016-02-03 18:40 ` [PATCH 2/3] xfs: don't use ioends for direct write completions Christoph Hellwig
2016-02-05 21:57 ` Darrick J. Wong
2016-02-05 22:36 ` Dave Chinner [this message]
2016-02-08 1:00 ` Dave Chinner
2016-02-08 6:17 ` Dave Chinner
2016-02-08 7:31 ` Christoph Hellwig
2016-02-08 9:16 ` Dave Chinner
2016-02-08 9:22 ` Christoph Hellwig
2016-02-03 18:40 ` [PATCH 3/3] xfs: fold xfs_vm_do_dio into xfs_vm_direct_IO Christoph Hellwig
2016-02-03 19:43 ` vfs/xfs: directio updates to ease COW handling V2 Jeff Moyer
2016-02-03 20:01 ` Darrick J. Wong
2016-02-03 21:53 ` Jeff Moyer
-- strict thread matches above, loose matches on Subject: below --
2016-02-02 20:17 VFS/XFS: directio updates to ease COW handling Christoph Hellwig
2016-02-02 20:17 ` [PATCH 2/3] xfs: don't use ioends for direct write completions Christoph Hellwig
2016-02-03 13:52 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205223626.GN459@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).