From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:41885 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbcBHO1d (ORCPT ); Mon, 8 Feb 2016 09:27:33 -0500 Date: Mon, 8 Feb 2016 15:27:49 +0100 From: Jan Kara To: Dave Chinner Cc: Jan Kara , linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Mark Fasheh , Joel Becker , xfs@oss.sgi.com Subject: Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota Message-ID: <20160208142749.GD9451@quack.suse.cz> References: <1454596087-6814-1-git-send-email-jack@suse.cz> <1454596087-6814-2-git-send-email-jack@suse.cz> <20160205010519.GJ459@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160205010519.GJ459@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri 05-02-16 12:05:19, Dave Chinner wrote: > On Thu, Feb 04, 2016 at 03:28:05PM +0100, Jan Kara wrote: > > Add infrastructure for supporting get_nextdqblk() callback for VFS > > quotas. Translate the operation into a callback to appropriate > > filesystem and consequently to quota format callback. > > > > Signed-off-by: Jan Kara > > I'm a little confused here. What patchset is this dependent on? i.e. > what introduces the ->get_nextdqblk method? It depends on the patches Eric sent which introduce ->get_nextdqblk. > The patches I currently have in my XFS working tree introduce this > (quota: add new quotactl Q_XGETNEXTQUOTA) and everythign else is > dependent on this. I looked a coupl eof days ago and I wasnt' able > to find this in your tree. Yeah, I have this patch as well, I just didn't push out. > I'd much prefer that one of us publish a stable branch with just the > quotactl() infrastructure (i.e. commands and bits up to the > ->get_nextdqblk() callback) that we can then both base the different > subsystem implementations off, rather than one of us having to pull > in a whole tree of changes just to get the one commit we need... Sure, I have pushed out: 'getnextquota' branch into my tree git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git which contains the patches from Eric I carry (including fixups in comments other minor stuff I have found during final review). Can you please base XFS patches on top of this branch? Thanks! Honza -- Jan Kara SUSE Labs, CR