From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:28448 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbcBMCSf (ORCPT ); Fri, 12 Feb 2016 21:18:35 -0500 Date: Sat, 13 Feb 2016 13:18:32 +1100 From: Dave Chinner To: Deepa Dinamani Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, Arnd Bergmann , Theodore Ts'o , linux-kernel@vger.kernel.org Subject: Re: [RFC v2b 5/5] fs: xfs: change inode times to use vfs_time data type Message-ID: <20160213021832.GP19486@dastard> References: <20160212092153.GA2368@deepa-ubuntu> <1455270349-3187-1-git-send-email-deepa.kernel@gmail.com> <1455270349-3187-6-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455270349-3187-6-git-send-email-deepa.kernel@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Feb 12, 2016 at 01:45:49AM -0800, Deepa Dinamani wrote: > This is in preparation for changing VFS inode timestamps to > use 64 bit time. > The VFS inode timestamps are not y2038 safe as they use > struct timespec. These will be changed to use struct timespec64 > instead and that is y2038 safe. > But, since the above data type conversion will break the > end file systems, use vfs_time functions to access inode times. > > current_fs_time() will change along with vfs timestamp data > type changes. > > xfs_vn_update_time() is a .update callback for inode operations > and this needs to change along with vfs inode times. This code is all different in the current XFS for-next branch. XFS no longer has it's own internal timestamps - it only uses the timestamps in the struct inode now. Cheers, Dave. -- Dave Chinner david@fromorbit.com