From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 15 Feb 2016 12:55:22 -0500 From: Jeff Layton To: Eryu Guan Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Paul E. McKenney" , Jan Kara , Eric Paris Subject: Re: [PATCH 2/2] fsnotify: turn fsnotify reaper thread into a workqueue job Message-ID: <20160215125522.03865cf4@tlielax.poochiereds.net> In-Reply-To: <20160215060310.GD29898@eguan.usersys.redhat.com> References: <1455495323-29605-1-git-send-email-jeff.layton@primarydata.com> <1455495323-29605-2-git-send-email-jeff.layton@primarydata.com> <20160215060310.GD29898@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, 15 Feb 2016 14:03:10 +0800 Eryu Guan wrote: > On Sun, Feb 14, 2016 at 07:15:23PM -0500, Jeff Layton wrote: > > We don't require a dedicated thread for fsnotify cleanup. Switch it over > > to a workqueue job instead that runs on the system_unbound_wq. > > > > In the interest of not thrashing the queued job too often when there are > > a lot of marks being removed, we delay the reaper job slightly when > > queueing it, to allow several to gather on the list. > > > > Cc: Jan Kara > > Cc: Eric Paris > > Cc: Andrew Morton > > Cc: Eryu Guan > > Signed-off-by: Jeff Layton > > With these two patches applied on top of r.5-rc3, the same test passed > 2-hour stress run, also survived stress test that forks 5 processes > running the same test program for 30 minutes. > > Thanks for looking into this! > > Eryu Thanks for reporting and testing the patches. Yes, I tested them too while running your reproducer and watched the size of the inotify_inode_mark slab. It seemed to stay pretty stable with these patches as well. Andrew, would you mind picking up these patches since you merged the original one? Thanks, -- Jeff Layton