From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
Dmitry Kasatkin <d.kasatkin@samsung.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Kees Cook <keescook@chromium.org>, Dave Young <dyoung@redhat.com>,
linux-fsdevel@vger.kernel.org,
Dmitry Kasatkin <dmitry.kasatkin@huawei.com>
Subject: Re: [PATCH] vfs: forbid write access when reading a file into memory
Date: Tue, 16 Feb 2016 22:43:33 +0100 [thread overview]
Message-ID: <20160216214333.GF25240@wotan.suse.de> (raw)
In-Reply-To: <1455656045-21463-1-git-send-email-zohar@linux.vnet.ibm.com>
On Tue, Feb 16, 2016 at 03:54:05PM -0500, Mimi Zohar wrote:
> From: Dmitry Kasatkin <d.kasatkin@samsung.com>
>
> This patch is based on top of the "vfs: support for a common kernel file
> loader" patch set. In general when the kernel is reading a file into
> memory it does not want anything else writing to it.
>
> The kernel currently only forbids write access to a file being executed.
> This patch extends this locking to files being read by the kernel.
>
> Changelog:
> - moved function to kernel_read_file() - Mimi
> - updated patch description - Mimi
>
> Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@huawei.com>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
BTW I don't see your common read work on linux-next yet, would
you resend this later after that queue of patches get merged?
Reviewed-by: Luis R. Rodriguez <mcgrof@kernel.org>
Luis
next prev parent reply other threads:[~2016-02-16 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 20:54 [PATCH] vfs: forbid write access when reading a file into memory Mimi Zohar
2016-02-16 21:43 ` Luis R. Rodriguez [this message]
2016-02-19 13:39 ` Mimi Zohar
2016-02-16 21:54 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216214333.GF25240@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=d.kasatkin@samsung.com \
--cc=dmitry.kasatkin@huawei.com \
--cc=dyoung@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).