From: Theodore Ts'o <tytso@mit.edu>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vfs: make sure struct filename->iname is word-aligned
Date: Fri, 19 Feb 2016 10:00:27 -0500 [thread overview]
Message-ID: <20160219150027.GD20458@thunk.org> (raw)
In-Reply-To: <878u2heq4y.fsf@rasmusvillemoes.dk>
On Thu, Feb 18, 2016 at 09:10:21PM +0100, Rasmus Villemoes wrote:
>
> Sure, that would work as well. I don't really care how ->iname is pushed
> out to offset 32, but I'd like to know if it's worth it.
Do you have access to one of these platforms where unaligned access is
really painful? The usual thing is to benchmark something like "git
stat" which has to stat every single file in a repository's working
directory. If you can't see it there, it seems unlikely you'd see it
anywhere else, yes?
- Ted
next prev parent reply other threads:[~2016-02-19 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 22:49 [PATCH 1/2] vfs: make sure struct filename->iname is word-aligned Rasmus Villemoes
2016-02-16 22:49 ` [PATCH 2/2] vfs: don't always include audit-specific members of struct filename Rasmus Villemoes
2016-02-16 22:57 ` [PATCH 1/2] vfs: make sure struct filename->iname is word-aligned Al Viro
2016-02-18 20:10 ` Rasmus Villemoes
2016-02-19 15:00 ` Theodore Ts'o [this message]
2016-02-22 23:59 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219150027.GD20458@thunk.org \
--to=tytso@mit.edu \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).