From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:52585 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948656AbcBSSdU (ORCPT ); Fri, 19 Feb 2016 13:33:20 -0500 Date: Fri, 19 Feb 2016 19:33:42 +0100 From: Jan Kara To: Eric Sandeen Cc: Jan Kara , linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Mark Fasheh , Joel Becker , xfs@oss.sgi.com Subject: Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota Message-ID: <20160219183342.GH30068@quack.suse.cz> References: <1454596087-6814-1-git-send-email-jack@suse.cz> <1454596087-6814-2-git-send-email-jack@suse.cz> <56C7518E.4020204@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C7518E.4020204@sandeen.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri 19-02-16 11:31:58, Eric Sandeen wrote: > > > On 2/4/16 8:28 AM, Jan Kara wrote: > > Add infrastructure for supporting get_nextdqblk() callback for VFS > > quotas. Translate the operation into a callback to appropriate > > filesystem and consequently to quota format callback. > > > > Signed-off-by: Jan Kara > > --- > > fs/ext4/super.c | 1 + > > fs/quota/dquot.c | 39 +++++++++++++++++++++++++++++++++++++++ > > fs/reiserfs/super.c | 1 + > > include/linux/quota.h | 3 +++ > > include/linux/quotaops.h | 3 +++ > > 5 files changed, 47 insertions(+) > > > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > > index f1b56ff01208..51649f442bf6 100644 > > --- a/fs/ext4/super.c > > +++ b/fs/ext4/super.c > > @@ -1100,6 +1100,7 @@ static const struct dquot_operations ext4_quota_operations = { > > .write_info = ext4_write_info, > > .alloc_dquot = dquot_alloc, > > .destroy_dquot = dquot_destroy, > > + .get_next_id = dquot_get_next_id, > > }; > > Hi Jan, doesn't this also need to set: > > > + .get_nextdqblk = dquot_get_next_dqblk, > > in ext4_qctl_sysfile_operations? Indeed, thanks for catching this. Patch added (with your authorship and sign-off) into my tree and this time I've properly tested Q_GETNEXTQUOTA for ext4 with quota in hidden inodes indeed works (previously I've tested only visible quota files). Honza -- Jan Kara SUSE Labs, CR