linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Pushpal Sidhu <psidhu@gateworks.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: ubifs+overlayfs
Date: Mon, 22 Feb 2016 08:19:21 +1100	[thread overview]
Message-ID: <20160221211921.GA25832@dastard> (raw)
In-Reply-To: <CAFLxGvx3Xe3pYPd=4sQR-_3_x=J9RsF7uhYpVK8EtbrcuV0kZA@mail.gmail.com>

On Sun, Feb 21, 2016 at 03:27:18PM +0100, Richard Weinberger wrote:
> Cc'ing linux-mtd.
> 
> On Sat, Feb 20, 2016 at 1:02 AM, Pushpal Sidhu <psidhu@gateworks.com> wrote:
> > It seems that overlayfs requires RENAME_WHITEOUT and RENAME_EXCHANGE.
> > However, these two flags aren't currently supported in ubifs (or
> > anything other than ext4, f2fs, and xfs). This causes any atomic
> > renames to fail (e.g. using 'mv' command).
> 
> Hmm, right. I always thought overlayfs does checks at mount time.
> But apparently I was wrong.
> Thanks for pointing this out.

It doesn't check any of the requirements it has from the underlying
filesystem. e.g. overlay requires DT_CHR for detecting whiteouts,
but it doesn't check if the upper filesystem actually supports
DT_CHR or not, and hence will fail to detect whiteouts correctly on
such filesystems. I've been pushing people to fix this, so maybe
patches will appear in the not too distant future...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-02-21 21:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20  0:02 ubifs+overlayfs Pushpal Sidhu
2016-02-21 14:27 ` ubifs+overlayfs Richard Weinberger
2016-02-21 21:19   ` Dave Chinner [this message]
2016-02-22 14:05     ` ubifs+overlayfs Vivek Goyal
2016-02-22 20:44   ` ubifs+overlayfs Pushpal Sidhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221211921.GA25832@dastard \
    --to=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=psidhu@gateworks.com \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).