From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org
Subject: [RFC] hpfs_unlink() deadlock
Date: Wed, 24 Feb 2016 00:37:04 +0000 [thread overview]
Message-ID: <20160224003704.GO17997@ZenIV.linux.org.uk> (raw)
Since "HPFS: Introduce a global mutex and lock it on every callback
from VFS" we had a deadlock in the "can't delete directory entry due to
lack of space, try to truncate the sucker first" path - hpfs_lock() held
through the area that contains notify_change() and hpfs_setattr() grabs
it again. BKL != mutex...
We could try to deal with that, but really, why not simply fail with
-ENOSPC there? It still can happen, even after truncate, so it's not as if
the userland didn't have to cope with it. And doing that would eliminate
the last user of dentry_unhash(), allowing to kill that crap as well...
next reply other threads:[~2016-02-24 0:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 0:37 Al Viro [this message]
2016-02-24 20:29 ` [RFC] hpfs_unlink() deadlock Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224003704.GO17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).