From: Amber Thrall <amber@thrall.me>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/1] fs: strncmp() for user space buffers
Date: Sun, 28 Feb 2016 15:39:08 -0800 [thread overview]
Message-ID: <20160228233908.GA1982@ARCH> (raw)
In-Reply-To: <20160228230303.GQ17997@ZenIV.linux.org.uk>
On 02/28, Al Viro wrote:
> On Sun, Feb 28, 2016 at 02:50:22PM -0800, Amber Thrall wrote:
> > The simple_strncmp_to_buffer() function provides an easier method for
> > developers to compare a kernel space buffer against user space data. This
> > process is done in a few drivers and may be simplified to a single function.
>
> *blink*
>
> The name is rather confusing and I would say that semantics is unexpected
> as well. I would like to see proposed users of that primitive...
Apologies for the confusing name, struggled to find an appropriate name
while staying consistent with the naming schemes of
simple_read/write_to_buffer() functions, as it based off of them. I'd
love to hear alternative names.
I saw possible uses for this proposed function being an easy way to
interact with debugfs, via their write file operation. For
example in the function xenvif_write_io_ring() the string "kick" is
checked for against a user space buffer.
Thanks for the fast reply.
next prev parent reply other threads:[~2016-02-28 23:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 22:50 [PATCH 1/1] fs: strncmp() for user space buffers Amber Thrall
2016-02-28 23:03 ` Al Viro
2016-02-28 23:10 ` Al Viro
2016-02-28 23:39 ` Amber Thrall [this message]
2016-02-29 2:10 ` Al Viro
2016-02-29 15:41 ` Amber Thrall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228233908.GA1982@ARCH \
--to=amber@thrall.me \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox