From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Pavel Emelyanov <xemul@parallels.com>,
Andrew Morton <akpm@linux-foundation.org>,
syzkaller <syzkaller@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: fs: uninterruptible hang in handle_userfault
Date: Tue, 1 Mar 2016 19:59:58 +0000 [thread overview]
Message-ID: <20160301195957.GD17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFyqy2JYoVe_hQhE7gBRZqE7C9qn_ZYJ_B1g9sTQQF6OxQ@mail.gmail.com>
On Tue, Mar 01, 2016 at 11:56:22AM -0800, Linus Torvalds wrote:
> (a) special-case the PF_EXITING case for usefaultfd, something like
>
> diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
> index 50311703135b..66cdb44616d5 100644
> --- a/fs/userfaultfd.c
> +++ b/fs/userfaultfd.c
> @@ -287,6 +287,12 @@ int handle_userfault(struct vm_area_struct
> *vma, unsigned long address,
> goto out;
>
> /*
> + * We don't do userfault handling for the final child pid update.
> + */
> + if (current->flags & PF_EXITING)
> + goto out;
Umm... Probably a dumb question, but would that suffice when e.g. another
thread is just starting to dump core?
next prev parent reply other threads:[~2016-03-01 19:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 11:29 fs: uninterruptible hang in handle_userfault Dmitry Vyukov
2016-03-01 19:56 ` Linus Torvalds
2016-03-01 19:59 ` Al Viro [this message]
2016-03-01 20:06 ` Linus Torvalds
2016-03-02 0:48 ` Al Viro
2016-03-02 14:55 ` Andrea Arcangeli
2016-03-02 17:03 ` Linus Torvalds
2016-03-02 17:34 ` Andrea Arcangeli
2016-03-03 7:14 ` Sedat Dilek
[not found] ` <CA+55aFzAUx01f31X6KhZMDddzbnN=rsyzV3nLF=C7FS22m9X=Q@mail.gmail.com>
2016-03-03 7:46 ` Sedat Dilek
2016-03-03 12:48 ` Andrea Arcangeli
2016-03-01 20:28 ` Linus Torvalds
2016-03-02 9:16 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301195957.GD17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).