From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:38301 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbcCAVey (ORCPT ); Tue, 1 Mar 2016 16:34:54 -0500 Date: Wed, 2 Mar 2016 08:34:51 +1100 From: Dave Chinner To: zhangaihua1@huawei.com Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] remove warn when bdi is unregisterd in __mark_inode_dirty(). Message-ID: <20160301213451.GJ30721@dastard> References: <1456729434-15737-1-git-send-email-zhangaihua1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456729434-15737-1-git-send-email-zhangaihua1@huawei.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Feb 29, 2016 at 03:03:54PM +0800, zhangaihua1@huawei.com wrote: > From: zhangaihua > > When a disk is ejected, we try to do the operation 'ls', it will fails > because device is gone. > > Currently we do a WARN() which does not seem to be the right thing. > Convert it to a ratelimited kernel warning. I don't think this is a good idea - the stack trace is required to determine what code has failed to detect that the device has gone and is trying to continue onwards without handling errors correctly. IMO, iterate_dir() should be fixed to do the right thing when errors have occurred.... Cheers, Dave. -- Dave Chinner david@fromorbit.com