linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Frank Sorenson <sorenson@redhat.com>,
	linux-fsdevel@vger.kernel.org, dwysocha@redhat.com,
	lvaz@redhat.com
Subject: Re: [PATCH 0/5] Add trace events for filesystem freeze/thaw events
Date: Thu, 3 Mar 2016 09:47:30 +1100	[thread overview]
Message-ID: <20160302224730.GP29057@dastard> (raw)
In-Reply-To: <20160302214744.GN17997@ZenIV.linux.org.uk>

On Wed, Mar 02, 2016 at 09:47:44PM +0000, Al Viro wrote:
> On Wed, Mar 02, 2016 at 01:01:54PM -0600, Frank Sorenson wrote:
> Let's provide a sane stable ABI for the things it's going to be
> used for.  Because _this_ is very likely to end up with
> "something needs to keep track of those events boot-to-shutdown" ->
> "something in systemd guts will be keeping track of those and
> broadcasting the collected information on state over dbus for the
> rest of dbus-infested system to see" -> "touch any details and you
> break real userland code" -> "it's cast in stone forever".  With
> systemd folks not particularly happy about the details, but even
> less happy about the need to make the already grotty code parsing
> those depend on the kernel version.
> 
> And as much as I don't like Lennart et.al., in this case they would
> be perfectly justified.  Information in question is potentially interesting,
> due to the form it is presented in one really needs to keep track of all
> messages since boot to make any use of it and it's clearly a job for
> a long-running daemon to collect those - nothing else would be able to.
> And once such a daemon starts using that, its authors would have very good
> reasons to demand the fucking ABI to be fucking stable.  After all, they
> weren't the ones who came up with the nasty details we might want to change.
> 
> So let's get it right.  Preferably - without need for boot-to-shutdown
> tracking just to mirror the state.  What do we really want?
> 
> * an ioctl to query the state (frozen/freezing/not frozen) for something in
> util-linux to use?
> 
> * /proc/fs/freezing and /proc/fs/frozen, with ->s_id of affected filesystems
> or, pehaps, one file with (frozen|freezing) + ->s_id?
> 
> * ability to audit on state changes?  That'd need some thought re what to
> do when some joker freezes the fs syslogd is logging to...
> 
> * something else entirely?

Such as:

https://lkml.org/lkml/2015/6/16/456

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-03-02 22:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 19:01 [PATCH 0/5] Add trace events for filesystem freeze/thaw events Frank Sorenson
2016-03-02 19:01 ` [PATCH 1/5] fs: simplify freeze_super()/thaw_super() exit handling Frank Sorenson
2016-03-02 20:06   ` Al Viro
2016-03-02 19:01 ` [PATCH 2/5] fs/block_dev.c: simplify freeze_bdev() and thaw_bdev() " Frank Sorenson
2016-03-02 19:01 ` [PATCH 3/5] fs: add trace events for freeze_super() and thaw_super() Frank Sorenson
2016-03-02 20:12   ` Al Viro
2016-03-02 19:01 ` [PATCH 4/5] fs/block_dev.c: add trace events for freeze_bdev() and thaw_bdev() Frank Sorenson
2016-03-02 19:01 ` [PATCH 5/5] fs: enable filesystem freeze/thaw events Frank Sorenson
2016-03-02 20:15   ` Al Viro
2016-03-02 21:47 ` [PATCH 0/5] Add trace events for " Al Viro
2016-03-02 22:47   ` Dave Chinner [this message]
2016-03-02 23:22     ` Al Viro
2016-03-02 23:52       ` Dave Chinner
2016-03-03 11:18 ` Dave Wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302224730.GP29057@dastard \
    --to=david@fromorbit.com \
    --cc=dwysocha@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lvaz@redhat.com \
    --cc=sorenson@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).