From: Christoph Hellwig <hch@infradead.org>
To: Bob Peterson <rpeterso@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Al Viro <viro@ZenIV.linux.org.uk>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [vfs PATCH v2 2/4] VFS: Add new __generic_iomap_fiemap interface
Date: Fri, 4 Mar 2016 09:05:32 -0800 [thread overview]
Message-ID: <20160304170532.GB15650@infradead.org> (raw)
In-Reply-To: <1457033515-7521-3-git-send-email-rpeterso@redhat.com>
> +typedef int (iomap_t)(struct address_space *mapping, loff_t pos,
> + ssize_t length, struct iomap *iomap, unsigned int flags);
No flags argument for reads vs writes, please - just use a separate
function pointer for potential future write operations using this
interface.
next prev parent reply other threads:[~2016-03-04 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 19:31 [vfs PATCH v2 0/4] vfs: Expand iomap interface to fiemap Bob Peterson
2016-03-03 19:31 ` [vfs PATCH v2 1/4] VFS: move iomap infrastructure from exportfs.h, add iomap to aops Bob Peterson
2016-03-04 17:04 ` Christoph Hellwig
2016-03-03 19:31 ` [vfs PATCH v2 2/4] VFS: Add new __generic_iomap_fiemap interface Bob Peterson
2016-03-04 17:05 ` Christoph Hellwig [this message]
2016-03-03 19:31 ` [vfs PATCH v2 3/4] GFS2: Add function __gfs2_io_map Bob Peterson
2016-03-03 19:31 ` [vfs PATCH v2 4/4] GFS2: Use new iomap interface for fiemap Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304170532.GB15650@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).