From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Karel Zak <kzak@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
util-linux@vger.kernel.org
Subject: Re: [ANNOUNCE] util-linux v2.28-rc1
Date: Sun, 13 Mar 2016 21:32:24 +0100 [thread overview]
Message-ID: <20160313203224.GR4295@var.home> (raw)
In-Reply-To: <20160311114701.oqbcsy2aiavj4ejz@ws.net.home>
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
Hello,
2.28-rc1 doesn't build on the Hurd system, see attached proposed patch.
sigset_t is not a structure on Hurd. Applications are not supposed to
assume what it is, and the first thing that sulogin.c does on it is
sigemptyset already anyway.
Samuel
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 404 bytes --]
diff --git a/login-utils/sulogin.c b/login-utils/sulogin.c
index 643712f..43ca0d4 100644
--- a/login-utils/sulogin.c
+++ b/login-utils/sulogin.c
@@ -859,7 +863,7 @@ int main(int argc, char **argv)
struct passwd *pwd;
struct timespec sigwait = { .tv_sec = 0, .tv_nsec = 50000000 };
siginfo_t status = {};
- sigset_t set = {};
+ sigset_t set;
int c, reconnect = 0;
int opt_e = 0;
int wait = 0;
next prev parent reply other threads:[~2016-03-13 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 11:47 [ANNOUNCE] util-linux v2.28-rc1 Karel Zak
2016-03-13 20:32 ` Samuel Thibault [this message]
2016-03-14 12:22 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313203224.GR4295@var.home \
--to=samuel.thibault@ens-lyon.org \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).